be able to set default editor for file type #5033
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wording on the notebook setting was very nonchalant before. Now we match other positron experimental features by making it as clear as possible that the notebooks are not ready for primetime yet. <img width="906" alt="image" src="https://github.com/user-attachments/assets/d3fb0c8f-ab31-42d5-94de-56fc5ac923a1"> <!-- Thank you for submitting a pull request. If this is your first pull request you can find information about contributing here: * https://github.com/posit-dev/positron/blob/main/CONTRIBUTING.md We recommend synchronizing your branch with the latest changes in the main branch by either pulling or rebasing. --> <!-- Describe briefly what problem this pull request resolves, or what new feature it introduces. Include screenshots of any new or altered UI. Link to any GitHub issues but avoid "magic" keywords that will automatically close the issue. If there are any details about your approach that are unintuitive or you want to draw attention to, please describe them here. --> ### QA Notes The setting key was changed to `positron.notebooks.usePositronNotebooksExperimental` from `positron.notebooks.usePositronNotebooks`. Which could cause issues it the tests manually set this flag. There doesn't appear to be any instances of this in the main positron repo, though.
### Intent Turn cnosole input test again as #4901 has been fixed in `main` ### Approach Removed `skip`. Also note that these tests will now run as part of the PR jobs as requested by dev. ## QA Notes Tests pass in CI
These changes fix a number of syntax higlighting issues caused by our TextMate grammar for R. Addresses #3688.
This change updates Positron to use 0.1.9 of the Kallichore supervisor. This update includes the following features: - Rework "start kernel" RPC to not return until kernel has actually started, and include stderr/stdout if it fails to start or connect. Addresses #4960. - Busy/idle time reporting, intended for use in Posit Workbench. - 20 second timeout to avoid hanging when waiting for a ZeroMQ socket connect. - Bearer token auth; RPCs that change state now check the token (already supplied by Positron). ### QA Notes This is mostly internal improvements; #4690 has an example that can be used to create startup failures.
Addresses #4870 by adding a new `Manual` startup behavior, that never automatically starts.
Addresses #4887 by making sure the correct order of action happens: 1. Shutdown the Reticulate Python kernel 2. Restart the R session 3. Start a new reticulate session --------- Signed-off-by: Daniel Falbel <dfalbel@gmail.com> Co-authored-by: Jonathan <jonathan@rstudio.com>
- Addresses: #4864 - updates the prefixes for web IndexedDB databases and stores to use `positron` instead of `vscode` - we don't delete the existing stores that are prefixed with `vscode` I've done some testing on a dev build of Server Web on Mac and a local release build of Positron on Workbench on Ubuntu 24. ### QA Notes - this change impacts Positron Web / Server Web only - the data stores are working if: - you're seeing the renamed databases and stores in Developer Tools > Application > Storage > IndexedDB - the layout state is being persisted when you close and reopen Positron in the same browser; for example: 1. Open up a folder in Positron Web / Server Web 2. Command Prompt > View: Toggle Zen Mode 3. Close the browser 4. Open up the same folder in the same browser in Positron Web / Server Web 5. You should still be in Zen Mode
Addresses #4874 Needs codicons from: posit-dev/positron-codicons#6 Needs ark side: posit-dev/ark#589 This PR is an initial implementation of the connections pane into Positron core. It's still missing a lot of functionality, but will eventually be equivalent to the current positron-connections extension. TODO: - [x] Workspace storage of previous connections - [x] Setting to opt-in for the new implementation - [x] Button to open data explorer for a `Table` or `View` - [x] Codicons for most common DB data types (schema, collections, etc) and for creating a new connection - [x] Review event listeners disposing - [x] Implement Python side of new GetMetadata RPC - [x] Implement refresh connections - [x] Display the field type - [x] Display the language for each connection - [x] Review error handling - [x] Fix smoke tests (smoke tests are passing locally) - [x] Fix integration tests - [x] Rename 'Connections Core' to just 'Connections' - [x] Support for the focus event Demo: https://github.com/user-attachments/assets/9e7b7905-3c1b-421d-a9e4-6c8e5d3b3b94 Must be enabled with: 
superseding #4670 since i really messed up git gymnastics there 😩 see other PR for details/review --------- Signed-off-by: Isabel Zimmerman <54685329+isabelizimm@users.noreply.github.com> Co-authored-by: positron-bot[bot] <173392469+positron-bot[bot]@users.noreply.github.com> Co-authored-by: sharon <sharon-wang@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #2933
QA Notes