Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement connections list screen #5153

Open
wants to merge 32 commits into
base: main
Choose a base branch
from

Conversation

dfalbel
Copy link
Contributor

@dfalbel dfalbel commented Oct 24, 2024

Adresses #5107.

Demo usage:

Screen.Recording.2024-10-30.at.12.57.59.mov
TODO:
  • Rename action bar for specific schema navigation component
  • Initial implementation of the list connections view
  • Implement styles for the list connections view
  • Correctly design the action bar for the list view
  • Allow deleting a saved connection
  • Show only the selected connection in the schema view
  • Secondary action bar in the schema view (with details about the selected connection instance)
  • Don't show top level connection when exploring schema. Requires instances to always be in the expanded state - Ended up refactoring the cache structure.
  • Connection Instances should send onChangeConnections event when their status changes.
  • Resume connection modal
  • Add Copy button behavior for the resume connection modal
  • Add Edit button behavior for the connections modal
  • Add Resume connections button behavior
  • Refresh schema navigation action bar
  • Bug: Refreshing causes the expanded state to be reset.
  • Bug: Code is not being correctly restored when the IDE restarts.
  • Fix heights for the List component - so it scrolls correctly in the presence of multiple connections.
  • Make sure scrolluing works, and that we save scroll state
  • %connection_view conn should direct to schema explorer view
  • Remove filters for now
  • localize button titles in action bars

Follow up PR:

@dfalbel dfalbel changed the title Move schema navigation to a separate component Implement connections list screen Oct 24, 2024
@dfalbel dfalbel marked this pull request as ready for review October 30, 2024 16:41
@petetronic petetronic added this to the 2024.12.0 Pre-Release milestone Oct 30, 2024
@petetronic
Copy link
Collaborator

Let's wait until we branch for 2024.11, and once main is open for prerelease 2024.12 changes we can review and plan to merging this on main (likely tomorrow).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants