Add support for SYS_clone3. #119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
en4bz
reviewed
Oct 11, 2022
| @@ -675,7 +694,7 @@ intercept_routine(struct context *context) | |||
| * the clone_child_intercept_routine instead, executing | |||
| * it on the new child threads stack, then returns to libc. | |||
| */ | |||
| if (desc.nr == SYS_clone && desc.args[1] != 0) | |||
| if (is_clone_syscall(desc.nr) && desc.args[1] != 0) | |||
There was a problem hiding this comment.
The arguments are not the same here. desc.args[1] is the stack pointer in clone. The stack pointer for clone3 is desc.args[0]->stack.
#ifdef SYS_clone3
else if(desc.nr == SYS_clone3 && ((struct clone_args*) desc.args[0])->stack != 0) {
return (struct wrapper_ret){
.rax = context->rax, .rdx = 2 };
}
#endif
|
@andyrudoff ever since @GBuella left Intel there have been almost no updates to this project and small bugs like this are going unfixed. You're listed as the main contact for pmem so can you assign someone from your team to help merge these PRs or add me to the pmem group so that I merge these myself? |
|
Fixed, including tests, in #123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115.