Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added option to download zip #94

Merged
merged 7 commits into from
Oct 16, 2024

Conversation

ae94
Copy link
Contributor

@ae94 ae94 commented Jun 17, 2023

What does it do?

Allow to download a zip of all config files

Why is it needed?

Accessing remote configs

How to test it?

Related issue(s)/PR(s)

Closes #54

@boazpoolman boazpoolman self-requested a review June 17, 2023 21:50
@boazpoolman boazpoolman self-assigned this Jun 17, 2023
server/services/main.js Outdated Show resolved Hide resolved
@reslear
Copy link

reslear commented Feb 3, 2024

Hi everyone, any updates ?)

@boazpoolman
Copy link
Member

This feature is not a priority for me right now.

I've put some feedback on this PR.
If anybody wishes to fix that feedback I'll be happy to merge and release this to NPM.

@reslear
Copy link

reslear commented Oct 14, 2024

@boazpoolman Would be cool to see this in the new v2 version as a new feature)

@boazpoolman
Copy link
Member

@reslear I completely agree!

It's hard for me to justify spending time on these features without anything in return.
I try my best by fixing bugs, and now supporting Strapi 5 in my free time.

If anybody wants to implement this feature on v2 I would be happy to review and merge it in!

Alternatives are for you to sponsor me so that I can spend more time on all my Open Source projects. You can do so through Github Sponsors: https://github.com/sponsors/boazpoolman

Or you can hire me through my company PluginPal to implement this feature for the plugin. If that's something that sounds interesting to you, please contact info@pluginpal.io.

@ae94
Copy link
Contributor Author

ae94 commented Oct 14, 2024

@boazpoolman just did the requested update and merged latest branch, lmk if anything else is needed!

@boazpoolman
Copy link
Member

@ae94 That was quick!

There are a couple linting issues but in general this looks fine.
I'll do a more thorough review soon and then we can get it merged.

@ae94
Copy link
Contributor Author

ae94 commented Oct 14, 2024

@ae94 That was quick!

There are a couple linting issues but in general this looks fine. I'll do a more thorough review soon and then we can get it merged.

Just noticed, fixing linting issues rn!

@TMSchipper
Copy link
Collaborator

TMSchipper commented Oct 16, 2024

@ae94 Thank you for your effort and work!

I've made a few changes, could you take a look?
The-Real-Established#1

@reslear
Copy link

reslear commented Oct 16, 2024

wow

feat: add response.data and fix styling for layout with download zip …
@boazpoolman
Copy link
Member

Nice work everyone!
Really nice this feature is finally ready for release 💯

@boazpoolman boazpoolman merged commit 8ba4dbb into pluginpal:master Oct 16, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dowload config
4 participants