Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tiny format icon names #57

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Fix tiny format icon names #57

merged 2 commits into from
Feb 21, 2024

Conversation

petschki
Copy link
Member

@mister-roboto
Copy link

@petschki thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@petschki
Copy link
Member Author

@jenkins-plone-org please run jobs

@petschki petschki requested a review from pbauer February 21, 2024 09:39
Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mauritsvanrees mauritsvanrees merged commit c275712 into main Feb 21, 2024
12 of 13 checks passed
@mauritsvanrees mauritsvanrees deleted the petschki-tinyicons-fix branch February 21, 2024 11:16
@thet
Copy link
Member

thet commented Feb 21, 2024

does this need an upgrade step?

@petschki
Copy link
Member Author

@thet yes. see plone/plone.app.upgrade#321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TinyMCE: Some inline_style icons are broken
5 participants