Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TinyMCE format icon names for alignment styles. #322

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

mauritsvanrees
Copy link
Member

Coming from Plone 5.2, you will have 'alignleft', which needs to be 'align-left', etc.

This fix reuses the code that Peter just did for the inline styles in PR #321.

Coming from Plone 5.2, you will have 'alignleft', which needs to be 'align-left', etc.
@mister-roboto
Copy link

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@mauritsvanrees
Copy link
Member Author

@jenkins-plone-org please run jobs

@mauritsvanrees
Copy link
Member Author

Jenkins on 6.1 has an unrelated error that was meanwhile fixed in CMFPlone master.
I merge.

@mauritsvanrees mauritsvanrees merged commit d0d3d4c into master Feb 21, 2024
4 of 6 checks passed
@mauritsvanrees mauritsvanrees deleted the maurits-alignment-styles-icon-fix branch February 21, 2024 16:55
@mauritsvanrees
Copy link
Member Author

Last week I accidentally made a release from this branch, instead of master.
I have merge the branch manually into master now.

@davisagli
Copy link
Member

@mauritsvanrees Maybe zest.releaser should have a feature to configure a list of allowed branches for making releases, so that it can stop you if you try to do it on a different branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants