Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tea -> pkgx for ci/cd #800

Merged
merged 29 commits into from
Oct 4, 2023
Merged

tea -> pkgx for ci/cd #800

merged 29 commits into from
Oct 4, 2023

Conversation

getneil
Copy link
Contributor

@getneil getneil commented Oct 3, 2023

No description provided.

@getneil getneil changed the title cicd wip: cicd Oct 3, 2023
@getneil getneil marked this pull request as ready for review October 3, 2023 05:08
@getneil getneil requested review from ABevier and mxcl October 3, 2023 05:09
@getneil getneil changed the title wip: cicd tea -> pkgx for ci/cd Oct 3, 2023
@@ -118,7 +112,7 @@ jobs:
- name: get gui version
id: gui-version
run: |
tea +stedolan.github.io/jq
pkgx +stedolan.github.io/jq
export version=$(echo $(cat package.json) | jq --raw-output .version)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could avoid line 115 and just do pkgx jq --raw… here

s3://dist.tea.xyz/tea.xyz/gui/tea-latest-arm64.dmg \
s3://dist.tea.xyz/tea.xyz/gui/tea-previous-arm64.dmg
s3://preview.gui.tea.xyz/release/ossapp-latest-arm64.dmg \
s3://preview.gui.tea.xyz/release/ossapp-previous-arm64.dmg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put the bucket id in a secret

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applied all of this.

Copy link
Member

@mxcl mxcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost

@mxcl mxcl merged commit b3c82be into main Oct 4, 2023
6 checks passed
@mxcl mxcl deleted the pkgx-cicd branch October 4, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants