render readme html scrapped via the server #781
Conversation
getneil
changed the title
|
how do we handle if readme has been updated by the package maintainer? atm, readme will only rebuild on release of new build. |
|
added issues: or just do all correctly remotely which i prefer |
| // TODO: support gitlab too | ||
| const changeSrcIfNeeded = (element: HTMLElement | Element) => { | ||
| const src = element.getAttribute("src"); | ||
| if (src?.startsWith("/")) { |
There was a problem hiding this comment.
I'm not sure this single condition will cover all the bases for relative URLs. I had found most examples of a relative path in the Openssl, lefthook, and xcodegen libraries. Among those three you get srcs like:
assets/imgs/foo.png
/assets/imgs/foo.png
./assets/imgs/foo.png
I had begun working on a remedy to this issue yesterday before the s3 solution was mentioned/implemented, and a regular expression covered the bases for relative paths we'd run in to in READMEs. Something like:
const isRelativePath = src?.match(/^[^\/]+\/[^\/].*$|^\/[^\/].*$/i)
There was a problem hiding this comment.
Note: This regex could probably be simplified, as it covers conditions we won't likely run in to as well
There was a problem hiding this comment.
@ryanml ill add that thank you, i missed out on that hehehe
DEMO: https://www.loom.com/share/71fab2e24ffe442da15102d62d76867c