Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix double click event handling in top bar #775

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Fix double click event handling in top bar #775

merged 1 commit into from
Aug 16, 2023

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Aug 16, 2023

Fixes: #770

By using self() in the on:dblclick handler for the topbar, child elements are prevented from inheriting their parent element's event.

Screen.Recording.2023-08-16.at.10.15.54.AM.mov

@ryanml ryanml self-assigned this Aug 16, 2023
ABevier
ABevier approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@ABevier ABevier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ABevier ABevier merged commit e9082da into main Aug 16, 2023
6 checks passed
@ABevier ABevier deleted the topbar-doubleclick-fix branch August 16, 2023 17:30
@mxcl
Copy link
Member

mxcl commented Aug 16, 2023

brilliant. this has been bothering me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ABevier ABevier ABevier approved these changes

Assignees

@ryanml ryanml

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Double back button click opens full window mode on MacOS
3 participants
@ryanml @mxcl @ABevier