Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport 2.11] prevent long recursive stack traces #24

Merged

Conversation

votrou
Copy link

@votrou votrou commented Oct 8, 2024

This backports the following PR: https://github.com/ray-project/ray/pull/43952/files
It prevents stack traces from recursing over and over until they hit a limit, and show unrelated errors to the user. This way the error stacktraces will be much clearer.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@lee1258561
Copy link

Please make the titled a bit more clear on the ray version we are cherry-picking Thanks!

@votrou votrou changed the title cherry pick log improvements [backport 2.11] prevent long recursive stack traces Oct 8, 2024
@votrou votrou merged commit 6d879cd into pinterest/main-2.10.0 Oct 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants