Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon: Update Icons [GESTALT-8450] #3808

Merged
merged 6 commits into from
Oct 21, 2024

Conversation

rlingineni
Copy link
Contributor

@rlingineni rlingineni commented Oct 17, 2024

Pull Request Instructions

Introducing new icons.

New Icons Introduced

  • ghost-fill
  • folder-fill

Icons Updated

  • ghost

Icons Removed

Note: These shouldn't have any usage. They are now available under a compact icons folder.

  • add-small
  • arrow-small-up-right
  • cancel-small
  • close-small
  • arrow-small-up-right
  • chevron-small-up
  • chevron-small-down
  • chevron-small-left
  • chevron-small-right

Diff

Interactive differences in the PR are available to see here.

Classic Icons
VR Icons

New Icons Introduced

Classic
VR

Links

  • Jira
  • [TDD](link to Paper doc)
  • [Figma](link to Figma file)

Checklist

  • Added unit tests
  • Added documentation + accessibility tests
  • Verified accessibility: keyboard & screen reader interaction
  • Checked dark mode, responsiveness, and right-to-left support
  • Checked stakeholder feedback (e.g. Gestalt designers, relevant feature teams)

@rlingineni rlingineni requested a review from a team as a code owner October 17, 2024 22:36
@rlingineni rlingineni added minor release Minor release major release Major release and removed minor release Minor release labels Oct 17, 2024
Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for gestalt ready!

Name Link
🔨 Latest commit 64f0266
🔍 Latest deploy log https://app.netlify.com/sites/gestalt/deploys/6716c20dc8fe58000852aad1
😎 Deploy Preview https://deploy-preview-3808--gestalt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rlingineni rlingineni merged commit ef13ca8 into pinterest:master Oct 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major release Major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants