the copy was supposed to be on the data not response #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous PR (https://github.com/pinterest/PINFuture/pull/32/files), the copy was supposed to add to the
data
property, but incorrectly set onresponse
.Ideally the same property should have the same attributes in both .h and .m, except the
readonly
. But its more of an issue for subclassing case, in which different attributes may result in two different ivars in subclass and parent class.