fix(deps): encodeurl@~2.0.0 #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/encodeurl@1.0.2 |
rxmarbles
approved these changes
Sep 12, 2024
UlisesGascon
approved these changes
Sep 16, 2024
| @@ -19,7 +19,7 @@ | |||
| "debug": "2.6.9", | |||
| "depd": "2.0.0", | |||
| "destroy": "1.2.0", | |||
| "encodeurl": "~1.0.2", | |||
| "encodeurl": "~2.0.0", | |||
There was a problem hiding this comment.
@UlisesGascon Please do not forget this before doing a new express security release.
The send with this merge request should be published first on npm. Thank you.
PS: Ping @rxmarbles as well.
|
Just published this as 0.19.1, in case @UlisesGascon you want to bump it in Express v4 some time. It looks like it's still pinned here: https://github.com/expressjs/express/blob/8e229f92752ad51462c868b99f6e6c2e559801b0/package.json#L55 Or we can unpin, I'm sure a PR is welcome on express for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: expressjs/express#5943 (comment)