Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CockroachDB: Hash Sharded Indexes. (#622) #639

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gnat
Copy link
Member

@gnat gnat commented Oct 11, 2022

Issue: #622

Implements "Sharding for Sequential Indexes" as noted in: #607

Major performance feature for "sequential data" for clusters (timestamps, etc).

@gnat
Copy link
Member Author

gnat commented Oct 11, 2022

@dantownsend This is the last major addition to complete the Cockroach integration. I separated it out of the main PR to reduce complexity.

It's optional, but very highly recommended.

I wanted to get feedback on the approach here, if there was a more elegant way to do this.

I have to step away for today, but I will get all the linters and such passing shortly.

Comment on lines +441 to +445
:param sharded:
If ``True`` and primary_key or index is also set ``True``, this index
will automatically use sharding across a cluster. Highly recommended
for sequence columns, such as: Serial, Timestamp.
Also known as Hash Sharded Index.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add something here saying 'CockroachDB only'.

If we're likely to have several database specific options, maybe we should namespace them. For example, cockroach_kwargs, or something.

@dantownsend
Copy link
Member

I have to step away for today, but I will get all the linters and such passing shortly.

@gnat Cool, no worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants