issue256 - rss/atom feeds, WIP #771
Conversation
| @@ -84,6 +84,19 @@ public function photosUpload($write = true) | |||
| return $utilityObj->returnValue('/photos/upload', $write); | |||
| } | |||
|
|
|||
| public function photosFeed($options = null, $feed_format = 'atom', $write = true) | |||
There was a problem hiding this comment.
Disregard this part, it's dead code. Sorry for including it in the pull request.
There was a problem hiding this comment.
I haven't had a look yet but feel free to prune code and update the pull request if needed.
|
This looks really good. Give me a day or two to merge it in or ask questions! |
|
awesome !!! |
| @@ -0,0 +1,46 @@ | |||
| <?php echo '<'; ?>?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
In case it looks weird: that's to avoid PHP short-tags problems. (There may be a prettier solution.)
|
@michelv Sorry I dropped the ball on this but what's remaining to merge this in? |
|
Hi Jaisen. The most important thing remaining is putting feed-atom.php in src/templates/feed/atom.php which I didn't manage to do at the time of this PR, then making some markup for the feed item so that photos are nice enough in feed readers. |
|
@michelv Alright, I'll keep this in mind in case I have time to finish it off before you get to it. |
Work in progress, it's better that more knowledgeable folks look into it now.
The idea is using the activity API for a feed ordered by descending upload date.
Among blocking problems in this pull request : feed-atom.php is used from the theme, photo sizes can't be customized in the feed, 304 support is non-existent.