Add feature gated Cow module paths
#900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 2, 2023
flyingsilverfin
pushed a commit
to typedb/dependencies
that referenced
this pull request
Oct 2, 2023
## What is the goal of this PR? We update to pest and pest-derive v2.7.4, which among other things purports to fix the error where [deriving Parser fails on "undeclared crate or module `alloc`"](pest-parser/pest#899) (pest-parser/pest#900).
flyingsilverfin
pushed a commit
to typedb/typeql
that referenced
this pull request
Oct 2, 2023
## What is the goal of this PR? We update to pest and pest-derive v2.7.4, which among other things purports to fix the error where [deriving Parser fails on "undeclared crate or module `alloc`"](pest-parser/pest#899) (pest-parser/pest#900). ## What are the changes implemented in this PR? We also clean up some compile warnings (unused imports and hashes).
flyingsilverfin
pushed a commit
to typedb/typedb-driver
that referenced
this pull request
Oct 2, 2023
## What is the goal of this PR? We update to pest and pest-derive v2.7.4, which among other things purports to fix the error where [deriving Parser fails on "undeclared crate or module `alloc`"](pest-parser/pest#899) (pest-parser/pest#900). ## What are the changes implemented in this PR? We also update README URLs and project descriptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generator currently wraps tags in an instance of
alloc::borrow::Cow. This PR changes that tostd::borrow::Cowconditional on thestdfeature flag being active.Closes #899.