Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mod.rs #895

Closed
wants to merge 134 commits into from
Closed

Update mod.rs #895

wants to merge 134 commits into from

Conversation

TheVeryDarkness
Copy link
Contributor

Fix an error of implementation of Display for OptimizedExpr, which will break the line when it contains a control character such as \n or \r.

@TheVeryDarkness
Adding typed node and typed parser
ad81703
@TheVeryDarkness
Update generator.rs
33e9892
@TheVeryDarkness
Create graph.rs
cf11997
@TheVeryDarkness
Add simple doc comment for TypedNode
d093260
@TheVeryDarkness
Remove old codes and add structs implementation
ccbcd48
@TheVeryDarkness
Add impl; add a missed declaration; fix macro errors
17c7f71
@TheVeryDarkness
Update generator.rs
613312a 
Change indent.
@TheVeryDarkness
Try using typed_state to implement typed parser
3cb3b02
@TheVeryDarkness
Remove typed_state
ae0af2e
@TheVeryDarkness
Before rewrite some codes
0889935
@TheVeryDarkness
Before remove outdated codes
0e207d2
@TheVeryDarkness
Update graph.rs
ee896de
@TheVeryDarkness
Change return value type; change function name; fixing errors
931011f
@TheVeryDarkness
Improve interfaces
9351355 
I'll delete some old codes later
@TheVeryDarkness
Removing BuiltInRule
2dc66e7
@TheVeryDarkness
Try fixing
178648d
@TheVeryDarkness
Before reconsidering built-in rules
755d915
@TheVeryDarkness
Remove rules notices on error
ed96cd5
@TheVeryDarkness
Fixing errors
8d7ba69
@TheVeryDarkness
Support automatic spaces and comments; move some codes outside proc m…
787d4fa 
…acro
@TheVeryDarkness
Derive Debug for each node
495815e
@TheVeryDarkness
Update generator.rs
bee0c83 
Fix a wrong change imported before
@TheVeryDarkness
More debugging information
a612b19
@TheVeryDarkness
Move more structure outside proc macro
0791e22
@TheVeryDarkness
Compress
2ab7de9
@TheVeryDarkness
Process comments and white spaces in another impl
b601419
@TheVeryDarkness
Add one more trait for never failed node
72029cc
@TheVeryDarkness
Added missed item in Seq and fixed recursive type error
a4c0af0
@TheVeryDarkness
Show more debugging information
99c7502
@TheVeryDarkness
Update graph.rs
4b50e64 
Fix warnings
@TheVeryDarkness
Update predefined_node.rs
6dbc823 
Merge a part of Rule into Atomic and NonAtomic; fix tests.
@TheVeryDarkness
Update graph.rs
33d0386 
Abandon Atomic and NonAtomic.
@TheVeryDarkness
Update graph.rs
df2cf95 
Separate codes into different modules.
@TheVeryDarkness
Update graph.rs
00456ce 
Compress nested option by flatten().
@TheVeryDarkness
Removing my codes.
b4db71b
@TheVeryDarkness
Merge remote-tracking branch 'upstream/master'
3509b5a
@TheVeryDarkness
Update mod.rs
69ebd01 
Fix an error of implementation of Display for OptimizedExpr, which will break the line when it contains a control character.
@TheVeryDarkness
Update mod.rs
523bcf7 
Fix an error of implementation of Display for OptimizedExpr, which will break the line when it contains a control character such as \n or \r.
@TheVeryDarkness TheVeryDarkness requested a review from a team as a code owner July 19, 2023 09:35
@TheVeryDarkness TheVeryDarkness requested review from NoahTheDuke and removed request for a team July 19, 2023 09:35
tomtau
tomtau approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheVeryDarkness it seems ok -- can you perhaps add unit tests that demonstrate the bug this change fixed?

@TheVeryDarkness
Improve the impl of Display for OptimizedExpr
bfa72cf 
Improve the implementation of Display for OptimizedExpr, which will break the line when it contains a control character such as \n or \r.
@TheVeryDarkness
Add tests to impl of Display for OptimizedExpr.
da51856
@TheVeryDarkness
Merge remote-tracking branch 'fork' into patch-2
34e72f6
@TheVeryDarkness
Update Display::fmt for OptimizedExpr
665a813 
Make codes a little easier to read.
@TheVeryDarkness
Update tests of Display for OptimizedExpr
820d58e 
Add several tests and fix a test.
@TheVeryDarkness
Move tests about Display into a separate module
651380b
@TheVeryDarkness
Implement Display for Expr
614c134
@TheVeryDarkness
Add several tests to Display for Expr and OptimizedExpr
1993083
@TheVeryDarkness
Format tests in ast.rs and optimizer/mod.rs.
66bc30b
@TheVeryDarkness
Remove unnecessary to_owned() and format
58685d5
@TheVeryDarkness
Merge remote-tracking branch 'fork/patch-2' into patch-2
6f3c3e9
@TheVeryDarkness
Copy link
Contributor Author

@tomtau yes, I add several tests and add some improvement to my implementation.
By the way, I also implemented Display for Expr just now :)

@TheVeryDarkness
Copy link
Contributor Author

I'm wondering why github is showing the commit from another branch master but not patch2, which is used to deal with Display.

@TheVeryDarkness
Copy link
Contributor Author

Oops, I create the new branch based on my working branch by mistake. I'll create a new branch and a new pull request then.

TheVeryDarkness added a commit to TheVeryDarkness/pest that referenced this pull request Jul 20, 2023
@TheVeryDarkness
Merge needed codes from pest-parser#895
360ceca 
Not related changes included in previous pull request pest-parser#895.
@TheVeryDarkness TheVeryDarkness mentioned this pull request Jul 20, 2023
Merged
tomtau pushed a commit that referenced this pull request Jul 20, 2023
@TheVeryDarkness
Implement Display for Expr and OptimizedExpr (#896)
02cffe6 
* Merge needed codes from #895

Not related changes included in previous pull request #895.

* Add several tests about display

To cover more paths in Seq and Choice. Thanks for @tomtau to point it out in #896.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomtau tomtau tomtau approved these changes

@NoahTheDuke NoahTheDuke Awaiting requested review from NoahTheDuke NoahTheDuke is a code owner automatically assigned from pest-parser/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheVeryDarkness @tomtau