Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix about name of waypoints #610

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

renanr0
Copy link

@renanr0 renanr0 commented Oct 10, 2020

Ensure assign name of waypoint with empty string only if the original name has no value.

@perliedman
Copy link
Owner

After dragging the waypoint, the name should be cleared since it is no longer the same location. It's confusing if the old address is displayed even after dragging the waypoint.

Can you explain why you need this change?

@renanr0
Copy link
Author

renanr0 commented Oct 28, 2020

Sure, in some cases of use, it's necessary to use the name of waypoint instead of the address. For example, I name some waypoints with custom names (home, work ...), and when I drag these points I lost the name. I understand if the library prefers not to accept this change, I'm just sharing a different use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants