Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-7 Support of PMM FB versions. #3167

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

BupycHuk
Copy link
Member

PMM-7

I recently faced a problem with PMM Server not being able correctly process FB versions, this PR should fix the problem.

Link to the Feature Build: SUBMODULES-0

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

  • Links to related pull requests (optional).

@BupycHuk BupycHuk requested a review from a team as a code owner August 21, 2024 19:30
@BupycHuk BupycHuk requested review from idoqo and JiriCtvrtka and removed request for a team August 21, 2024 19:30
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.35%. Comparing base (a3c584a) to head (b089861).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3167   +/-   ##
=======================================
  Coverage   43.35%   43.35%           
=======================================
  Files         399      399           
  Lines       41658    41658           
=======================================
  Hits        18060    18060           
  Misses      21579    21579           
  Partials     2019     2019           
Flag Coverage Δ
managed 44.40% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ademidoff
Copy link
Member

ademidoff commented Aug 22, 2024

Does this completely remove the github.com/hashicorp/go-version package from managed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants