-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement PXB-3155 - Move keyring vault to component #1500
Implement PXB-3155 - Move keyring vault to component #1500
Conversation
https://jira.percona.com/browse/PS-8854 (cherry picked from commit 96b944152c7b2737fa317c695b07b584bac52bdd)
…ersion_v2 used https://jira.percona.com/browse/PS-8854 Vault version Vault_version_v2 keeps records history on backend. In some situations keyring_vault may get records for already deleted keys (with empty 'data' and 'deletion_time' set) while populating keyring component cache during its startup. At the moment keyring_vault cannot process such data records properly. This leads to component loading failure. To fix the issue data records parser updated to handle such deleted entries. They are skipped while populating component cache. (cherry picked from commit 92926e1533384d2a666e4a8d50f43540eff30451)
https://jira.percona.com/browse/PXB-3155 Moved the keyring vault from plugin to component. Adjusted the necessary tests to properly instantiate the component configuration.
|
Manual TestsWe still don't have a valid PS version with vault as component, so no jenkins:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
https://jira.percona.com/browse/PXB-3155
Cherry-picked relevant commits:
percona/percona-server@96b9441
percona/percona-server@92926e1
Adjusted PXB-related code to understand the vault as a component and fixed test cases.