Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brittle deduplication test cases #557

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

orangejulius
Copy link
Member

@orangejulius orangejulius commented Mar 2, 2022

This is an extension to #556 that uses GIDs and other brittle methods to expand deduplication test cases.

In the short term, it means we can do a better job of specifying exactly how we want results to appear when testing deduplication.

However, in the long term, it would likely mean occasional work to update GIDs or other test details to keep the tests up to date. For that reason we might not want to merge them.

Pennsylvania, IN and Pennsylvania Township, IN are technically not the
same place (the township includes the village/city/whatever it's
called).

However, we should deduplicate them, under our general rules of parents
with similar names being deduped.

If someone really wants the township they can type 'Pennsylvania
Township'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant