CodeEditor loading property considered by the Editor #11034
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to see tests for this particular use case not being covered, I will provide as soon as we have an approval about the issue and also the proposal (this PR) |
|
Preview: https://patternfly-react-pr-11034.surge.sh A11y report: https://patternfly-react-pr-11034-a11y.surge.sh |
kmcfaul
requested changes
Oct 9, 2024
| @@ -652,6 +653,7 @@ class CodeEditor extends React.Component<CodeEditorProps, CodeEditorState> { | |||
| onChange={this.onChange} | |||
| onMount={this.editorDidMount} | |||
| theme={isDarkTheme ? 'vs-dark' : 'vs-light'} | |||
| loading={loading} | |||
| {...editorProps} | |||
There was a problem hiding this comment.
editorProps should already allow loading to be passed. If we want loading to be a distinct property, we will need to add it to the props table.
There was a problem hiding this comment.
I missed that this already was in the props table and is unused.
kmcfaul
approved these changes
Oct 10, 2024
|
one more additional approver required, please any kind soul aroung? 🙏 😉 |
tlabaj
approved these changes
Oct 23, 2024
|
@Ginxo if you need this in v5, can you please change the base branch to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #11033
Additional issues: