Spec, for custom Scalars, cannot be satisfied #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lojure.spec.gen.alpha/sample` satisfiable for custom scalars, by moving the `any?` spec to the end, but keeping all other semantics the same.
|
Thanks and sorry for the slow response. I'm having issues building on MacOS Sonoma due to Boot incompatibility. Unfortunately, I'm not using Serene (or even Clojure) these days so, while I would like to fix this, I cannot justify spending too much more time on this (I've already tried several steps to get this to work but each problem resolved exposes a new problem). Are you able to build the project? |
|
Thank you for taking the time. Honestly, I didnt expect any response, to the issue. Yes, I am able to build the project and run the tests. I am already using this in my code.
|
- Restructure project directories to adhere to Clojure's convention. - Update .gitignore to include more development-related files. - Remove boot.properties and build.boot as the project transitions from Boot to tools.deps. - Introduce deps.edn to manage project dependencies, aliases, and build configurations. - Update the project to use the latest Clojure version and other dependencies. - Modify serene schema and test files to reflect the latest changes in the project. - Rename files and directories to match the new project structure. - Remove unnecessary cljs-specific code in serene_test.cljc. - Update GraphQL schema to include new scalar type Scalar_Instant and modify Object_EmailOrUsername to implement multiple interfaces.
- Added 'target' directory to .gitignore file to prevent compiled files from being tracked by git. - Created a new Clojure build script, build.clj, which includes functions for testing, compiling, cleaning, building and deploying the serene library. - Updated deps.edn file to include dependencies necessary for the build and deployment process. - Removed the com.github.seancorfield/expectations dependency from the cider and kaocha aliases in the deps.edn file. - Updated the source-uri in the codox alias in the deps.edn file to point to the new serene repository. - Added the com.walmartlabs/lacinia dependency to the test alias in the deps.edn file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the evaluation order of
:extendspecs, in order to makecojure.spec.gen.alpha/samplesatisfiable for custom scalars, by moving the
any?spec to the end, but keeping all other semantics the same.I actually liked the default
any?for custom scalars, and decided to keep it that way.scalar Timestamp{:extend {:Timestamp `inst?}}Before
After