BACK-1618: Inception LRT #731
Conversation
feat: InceptionLRT requested changes
feat: Inception integration, requested changes
src/dex/inception/inception.ts
Outdated
| exchangeData: swapData, | ||
| targetExchange: dexParams.vault, | ||
| swappedAmountNotPresentInExchangeData: true, | ||
| returnAmountPos: undefined, |
There was a problem hiding this comment.
Deposit function returns iShares, assume we can use it in the returnAmountPos
There was a problem hiding this comment.
Better to skip optimization for this case, since iShares might differ with real amount a user gets
There was a problem hiding this comment.
I assume that they assumed that input param amount might differ from iShares, but not that iShares might differ from what user (AugustusV6 in out case) received
Also, according to this simulation, Augustus received exactly what was passed (+1 wei dust)
deposit: 
balanceOf on Augustus:
Also, mint function on the token is simple and doesn't do any roundings
There was a problem hiding this comment.
So, for me looks like we can use returnAmountPos here without problems
No description provided.