Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linter error in gsuite_workspace_calendar_external_sharing.py #1383

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Fix linter error in gsuite_workspace_calendar_external_sharing.py #1383

merged 3 commits into from
Oct 10, 2024

Conversation

le4ker
Copy link
Member

@le4ker le4ker commented Oct 10, 2024 •
edited
Loading

Background

Linter in Github Action fails with:

rules/gsuite_activityevent_rules/gsuite_workspace_calendar_external_sharing.py:20:0: W1404: Implicit string concatenation found in call (implicit-str-concat)

Changes

  • Explicitly join the strings.
  • Updates Check Removed Rules workflow to use the develop branch.

@le4ker le4ker requested a review from a team as a code owner October 10, 2024 10:19
@le4ker le4ker enabled auto-merge (squash) October 10, 2024 10:31
@le4ker le4ker merged commit 67fa051 into develop Oct 10, 2024
9 checks passed
@le4ker le4ker deleted the panos/fix-linter-error branch October 10, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akozlovets098 akozlovets098 akozlovets098 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@le4ker @akozlovets098