[sync] Revert changes to aws_ami_modified_for_public_access.py/.yml (#48) #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Customers are seeing false positives with the recently-modified
aws_ami_modified_for_public_access.py/.ymlrule. This PR reverts the change to the original behavior which was correct.AWS docs on this: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/sharingamis-intro.html
The CLI command specifies that
Group=allis what makes an AMI public, not sharing the AMI with a user.Changes
aws_ami_modified_for_public_access.py/.ymlTesting