[WIP] feat: add initial CLProtocolFeeController implementation #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
chefburger
reviewed
Oct 21, 2024
|
|
||
| /// @notice Get the protocol fee for a pool given the conditions of this contract | ||
| /// @return protocolFee The pool's protocol fee, expressed in hundredths of a bip. The upper 12 bits are for 1->0 | ||
| function protocolFeeForPool(PoolKey memory poolKey) external pure override returns (uint24 protocolFee) { |
There was a problem hiding this comment.
Do we need some kind of whitelist here ? For example for some specific token pairs, we might want to manually give its initial protocolFee
chefburger
reviewed
Oct 21, 2024
| IProtocolFees(address(key.poolManager)).setProtocolFee(key, newProtocolFee); | ||
| } | ||
|
|
||
| function collectProtocolFee(address recipient, Currency currency, uint256 amount) external onlyOwner { |
There was a problem hiding this comment.
Do we need better granularity for the permission here ? For example, we might involve different roles for collect fee and set fee ?
(Of course, this could also be implemented in owner contract )
chefburger
reviewed
Oct 21, 2024
| } | ||
|
|
||
| /// @param fee If 1000, the protocol fee is 0.1%, cap at 0.4% | ||
| function _buildProtocolFee(uint24 fee) internal pure returns (uint24) { |
There was a problem hiding this comment.
are we sure it's always same fee for zeroForOne and oneForZero
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
TODO: