Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Weighted voting UI #10858

Open
wants to merge 34 commits into
base: develop
Choose a base branch
from
Open

Conversation

ChefMomota
Copy link
Contributor

@ChefMomota ChefMomota commented Oct 22, 2024


PR-Codex overview

This PR focuses on enhancing the voting system by introducing new vote types, updating interfaces, and improving the UI for casting and displaying votes, particularly for single-choice and weighted voting proposals.

Detailed summary

  • Added SingleVoteState and WeightedVoteState interfaces.
  • Introduced ProposalTypeName enum for vote types.
  • Updated Proposal interface to include type, scores, and scores_total.
  • Modified CastVoteModal to handle different vote types.
  • Created SingleVote and WeightedVote components for respective voting methods.
  • Improved VoteRow to display vote percentages for weighted votes.
  • Enhanced UI components for better styling and responsiveness.
  • Updated localization strings for new voting-related texts.
  • Refactored voting logic to accommodate new features and improve clarity.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Oct 22, 2024

Copy link

changeset-bot bot commented Oct 22, 2024

⚠️ No Changeset found

Latest commit: 38f2dd3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 4:23am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 4:23am
blog ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 4:23am
bridge ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 4:23am
games ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 4:23am
gamification ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 4:23am
uikit ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 4:23am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant