Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Invariant crash when swap trade breakdown #10664

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Sep 11, 2024

To reproduce:

https://pancakeswap.finance/swap?outputCurrency=0x0b33542240d6fA323c796749F6D6869fdB7F13cA

and input bnb to very large amount: 10000000000000000000000000000000000000000000000000000000000


PR-Codex overview

This PR focuses on enhancing error handling in the exchange.ts file by wrapping the route processing logic in a try-catch block, allowing for graceful failure and returning a structured response in case of errors.

Detailed summary

  • Added a try-catch block around the route processing logic.
  • In the catch block, returns an object with priceImpactWithoutFee set to undefined and lpFeeAmount set to null.
  • Maintained the existing logic for calculating routeFeePercent and updating outputAmountWithoutPriceImpact.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Sep 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 7:34am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2024 7:34am
blog ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2024 7:34am
bridge ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2024 7:34am
games ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2024 7:34am
gamification ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2024 7:34am
uikit ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2024 7:34am

Copy link

changeset-bot bot commented Sep 11, 2024

⚠️ No Changeset found

Latest commit: 971dead

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant