fix: Invariant crash when swap trade breakdown #10664
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce:
https://pancakeswap.finance/swap?outputCurrency=0x0b33542240d6fA323c796749F6D6869fdB7F13cA
and input bnb to very large amount: 10000000000000000000000000000000000000000000000000000000000
PR-Codex overview
This PR focuses on enhancing error handling in the
exchange.ts
file by wrapping the route processing logic in atry-catch
block, allowing for graceful failure and returning a structured response in case of errors.Detailed summary
try-catch
block around the route processing logic.catch
block, returns an object withpriceImpactWithoutFee
set toundefined
andlpFeeAmount
set tonull
.routeFeePercent
and updatingoutputAmountWithoutPriceImpact
.