Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Fetch isrefundable from rpc only when round is canceled #10475

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Aug 21, 2024


PR-Codex overview

This PR focuses on enhancing the functionality of the useIsRefundable hook and improving the HistoricalBet component's structure and readability. It introduces a new parameter for refund checks and refactors the rendering logic for bet results.

Detailed summary

  • Updated useIsRefundable to accept a second parameter (enabled).
  • Changed the condition for fetching refundable status to include enabled.
  • Refactored HistoricalBet to use a new BetLabel component for rendering bet results.
  • Simplified color mapping for bet results using roundColorMap.
  • Removed redundant functions for determining round color and prefix.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Aug 21, 2024

⚠️ No Changeset found

Latest commit: d8c431d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Aug 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 7:40am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2024 7:40am
blog ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2024 7:40am
bridge ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2024 7:40am
games ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2024 7:40am
gamification ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2024 7:40am
uikit ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2024 7:40am

@memoyil memoyil force-pushed the feature/perf_fetch_is_refundable_from_rpc_only_when_canceled branch 2 times, most recently from d474e1d to 59e4ccc Compare August 21, 2024 08:07
@memoyil memoyil changed the title perf: Fetch isrefundable from rpc only when round is canceled perf: Fetch isrefundable from rpc only when round is canceled and use v3 contract when is native false Aug 21, 2024
@memoyil memoyil changed the title perf: Fetch isrefundable from rpc only when round is canceled and use v3 contract when is native false perf: Fetch isrefundable from rpc only when round is canceled Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant