Add underlines to links #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary for good web accessibility and compliance with WCAG 2.0. Basically, if a link is only identified by color, it can't be used by people with vision issues. "Compliance F73: Failure of Success Criterion 1.4.1 due to creating links that are not visually evident without color vision"
|
Welcome! Congrats on your first pull request to the Primer theme. If you haven't already, please be sure to check out the contributing guidelines. |
|
Related to issue #44 |
|
Hi @dylanhthomas! I’m not a repo maintainer, but I suspect this change should first be proposed in GitHub’s Primer CSS styles. If it’s merged there, I think it would be much more likely that this theme will update its Primer CSS dependency 😃 |
added 2 commits
September 17, 2020 14:40
removed redundant hover style
this should fix the build error
|
Was alerted to the existance of primer/css. will put code there. |
|
Thank you so much @seshrs, I wasn't aware of the other repo, I was just aware of the theme. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary for good web accessibility and compliance with WCAG 2.0.
Basically, if a link is only identified by color, it can't be used by people with vision issues.
"Compliance F73: Failure of Success Criterion 1.4.1 due to creating links that are not visually evident without color vision"