Use javalin for params instead of servlet #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that javalin apps can still use getFormParams when using pac4j fixes pac4j#29
An application can and should expect after handlers to run even if auth fails, as otherwise resources that should have been cleaned up may not be cleaned up. Only later before handlers and the main request handler should be skipped.
|
LGTM Please fix the build: https://github.com/pac4j/javalin-pac4j/actions/runs/9070430660/job/24932389547?pr=286 and add class Javadocs. |
|
The build still fails: https://github.com/pac4j/javalin-pac4j/actions/runs/9079224769/job/24948043653?pr=286 |
|
Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that javalin apps can still use getFormParams
when using pac4j
fixes #29