This repository has been archived by the owner on Nov 11, 2018. It is now read-only.
Issue #381 clickable autocomplete #383
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
| autocompletion.run_command.connect(on_autocomplete_run_command); | ||
|
|
There was a problem hiding this comment.
Unnecessary blank lines (there should be only one on top and none on bottom).
…he hover selected command
| @@ -122,7 +124,7 @@ public class Autocompletion : Object { | |||
| return scrollable_list_view.is_valid_item_index(selected_index); | |||
| } | |||
|
|
|||
| public string? get_selected_command() { | |||
| public string? scrollable_list_view.get_item(selected_index).text { | |||
There was a problem hiding this comment.
This is the weirdest construct I have ever seen in Vala. I am completely unfamiliar with such syntax. How does this compile?!? Can you enlighten me?
It's not a method (no parentheses, unless the ones around selected_text are somehow counted), it's not a property (no get/set blocks), so what is it?
…) autocomplete functionality
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made autocomplete to work with mouse.
I know the issue was created just a few hours ago. And was not yet approved by p-e-w. But I decided to implement it anyway.