prototype conversion to new dropshot builder interface #6730
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of oxidecomputer/dropshot#1122, although that should be a non-breaking change, I wanted to test-convert all of Omicron over to the new thing to make sure I didn't run into any unexpected issues. This worked out pretty well (and there were no callers that didn't immediately invoke
start()
on theHttpServerStarter
).This won't be able to land until: