Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prototype conversion to new dropshot builder interface #6730

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

davepacheco
Copy link
Collaborator

As part of oxidecomputer/dropshot#1122, although that should be a non-breaking change, I wanted to test-convert all of Omicron over to the new thing to make sure I didn't run into any unexpected issues. This worked out pretty well (and there were no callers that didn't immediately invoke start() on the HttpServerStarter).

This won't be able to land until:

  • oxidecmoputer/dropshot#1122 lands
  • we release a new dropshot version
  • I update this PR to use the released version

@davepacheco
Copy link
Collaborator Author

For the record, this can't run in CI due to the local patch, but cargo xtask clippy and cargo nextest run --no-fail-fast were clean on commit c0ea923.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant