Add message for reading the Lock State of the system #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the reminder, once we've confirmed this is the right API I'll update the version and unit tests accordingly |
labbott
force-pushed
the
lock_state
branch
3 times, most recently
from
4eb60d3
to
dc4fb5a
Compare
labbott
force-pushed
the
lock_state
branch
6 times, most recently
from
8519b09
to
2591f0c
Compare
jgallagher
approved these changes
Feb 28, 2024
| use gateway_messages::SerializedSize; | ||
| use gateway_messages::SpResponse; | ||
|
|
||
| #[test] |
There was a problem hiding this comment.
Could you add a test for the new SpError::Vpd(VpdError::*) variants too? Should be basically the same as the SprotError tests I think.
The lock information is returned as an array of trailing data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now this is just the VPD state