verifier-cli: Persist artifacts as json instead of raw binary. #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This falls short of removing all binary encodings but it makes it possible for us to use the `verify` command to verify an attestation and persist the artifacts as JSON. Later we can use the `verify-attestation` and `verify-cert-chain` commands to re-verify the artifacts persisted by the `verify` command. Other commands like `attest` and `log` still need to be updated to use the JSON encoding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This falls short of removing all binary encodings but it makes it possible for us to use the
verifycommand to verify an attestation and persist the artifacts as JSON. Later we can use theverify-attestationandverify-cert-chaincommands to re-verify the artifacts persisted by theverifycommand.Other commands like
attestandlogstill need to be updated to use the JSON encoding.