Make toast copy more consistent #2504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Love the direction, thanks for doing this tedious stuff. |
|
The latest, with highlighting, and removing the |
|
Prettier is killing me. This sent me on an odyssey to see if addToast({ content: <>IP <HLs>{ephemeralIp.ip}</HLs> attached</> })but neither one can. Reconsidering my choice of career. |
|
The highlighting might make the secondary color text look too dim. 
Here's what it looks like with both in 
|
david-crespo
force-pushed
the
align_toast_copy
branch
from
df7f302
to
d90b1c7
Compare
david-crespo
force-pushed
the
align_toast_copy
branch
from
f52198b
to
4ecef06
Compare
| group-[.text-accent-secondary]:text-accent | ||
| group-[.text-error-secondary]:text-error | ||
| group-[.text-info-secondary]:text-info | ||
| ` |
There was a problem hiding this comment.
Mad scientist stuff. This is the CSS selector it generates.
.group.text-accent-secondary .group-\[\.text-accent-secondary\]\:text-accent {
// ...
}
david-crespo
force-pushed
the
align_toast_copy
branch
from
3308efc
to
63737d7
Compare
|
oh wild. I just got the error locally, so maybe it's not the runner! 
|
david-crespo
force-pushed
the
align_toast_copy
branch
from
63737d7
to
0656409
Compare
david-crespo
force-pushed
the
align_toast_copy
branch
from
0656409
to
69940ce
Compare
|
ok lmao. in a3d736b, I did a giant find-replace of 
|
david-crespo
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Thanks for doing all the fiddly work @charliepark. The toasts have been bothering me forever!
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Oct 30, 2024
oxidecomputer/console@f7d6daf...6eeab20 * [6eeab203](oxidecomputer/console@6eeab203) oxidecomputer/console#2525 * [bdc1c87c](oxidecomputer/console@bdc1c87c) oxidecomputer/console#2526 * [23824251](oxidecomputer/console@23824251) oxidecomputer/console#2508 * [78e7e26b](oxidecomputer/console@78e7e26b) oxidecomputer/console#2524 * [eb7f8567](oxidecomputer/console@eb7f8567) oxidecomputer/console#2504 * [df0dea4a](oxidecomputer/console@df0dea4a) oxidecomputer/console#2514 * [3474c6ce](oxidecomputer/console@3474c6ce) oxidecomputer/console#2522 * [af6a89e7](oxidecomputer/console@af6a89e7) oxidecomputer/console#2520 * [4e967560](oxidecomputer/console@4e967560) oxidecomputer/console#2512
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Oct 30, 2024
oxidecomputer/console@f7d6daf...6eeab20 * [6eeab203](oxidecomputer/console@6eeab203) oxidecomputer/console#2525 * [bdc1c87c](oxidecomputer/console@bdc1c87c) oxidecomputer/console#2526 * [23824251](oxidecomputer/console@23824251) oxidecomputer/console#2508 * [78e7e26b](oxidecomputer/console@78e7e26b) oxidecomputer/console#2524 * [eb7f8567](oxidecomputer/console@eb7f8567) oxidecomputer/console#2504 * [df0dea4a](oxidecomputer/console@df0dea4a) oxidecomputer/console#2514 * [3474c6ce](oxidecomputer/console@3474c6ce) oxidecomputer/console#2522 * [af6a89e7](oxidecomputer/console@af6a89e7) oxidecomputer/console#2520 * [4e967560](oxidecomputer/console@4e967560) oxidecomputer/console#2512
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the toasts across the app more consistent, and adds highlighting to the resource name (when available) for each of the toasts.
Closes #2499