[RFC] handle runtime shutdowns while tasks are being spawned #80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a runtime has been marked as shutting down before
spawn_blocking
iscalled, or before the blocking task is first scheduled, the
JoinHandle
willreturn a cancellation error. Currently, this panics, which tends to manifest as
test failures.
Instead, add a
RunError
wrapper that captures the cancellation situation.Callers might choose to bubble this error up or to squelch it -- unfortunately,
we can't make this decision.
I haven't written tests yet but I should be able to if this looks reasonble.
The API surface here is really unfortunate, but I can't see a better way to do
this than to propagate errors up the stack.