-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shift focus to monitor if at the edge of the screen #5
base: master
Are you sure you want to change the base?
Conversation
Oops, this seems to cause some random freezes, don't merge until I figure that one out 😓 |
How does this interact with multiple monitors in a given direction? Also I would prefer it to be implemented in shiftOrGetFocus, probably between the breakout and breakin code. |
Just like focusing windows, each dispatch of the movefocus command moves one monitor in that direction.
So after the while loop on line 1300? How do you want that to work with the return value though? It seems like the current code computes a node which should be focused and which is returned. Should it focus the monitor, then continue with the execution? Also, the crash I was talking about was not caused by me, it was a bug in hyprland with X11 windows, so this is safe to merge I also made a change to make the mouse cursor follow the monitor (though not windows individually as seems to be what dwindle does). This is what I'm used to from bspwm, but I could also change it |
What happens if two monitors border the same monitor though? Ideally focus would move to the monitor that borders more of the window.
Line 1405 in 90f36e3
Note that you'll have to account for the once option.
Make an option for it and its fine. |
@TheZoq2 Any news on this? |
No sorry, it has worked well enough for locally me to not bother updating it yet. I might get around to it eventually, but feel free to pick it up and finish what I started if you feel like it |
36fe20d
to
19ce41b
Compare
I reapplied the changes to v0.31.0 and created a patch for Nix, if anyone else wants to hack it together I'll put it below. I wish I knew more C++, I'd try to pick this up. I wanted to add basic support for shifting between monitors, but I couldn't figure out how.
|
Closes #2
Not sure if this is the idiomatic way of doing this, but it does seem to work. The only problem I've seen is that if there are no windows on a monitor, there is no indication that that monitor is focused