Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zh-fix_eng_punctuation] fix eng punctuation in chinese sentence #77

Merged
merged 6 commits into from
Aug 1, 2019

Conversation

inkydragon
Copy link

@inkydragon inkydragon commented Jun 10, 2018

Description

参见 #72

修复的问题

  1. 英文标点符号 ,.: 换为对应的中文标点 ,。:
  2. 删除句子之间,标点符号之后的空格
  3. 修复不正确的加粗 (未成功加粗,需要添加空格)
  4. 修复滥用的逗号,并列项中改为顿号
  5. 修复不正确的 Out of date 标记
  6. 添加新的 Out of date 标记 (有待检查是否有人开坑)
  7. 删除括号内最后的句号

发现的其他问题

(已标记,未修复)

  1. wiki link
  2. 图片引用
  3. 格式缩进

Status

  • WIP
  • Pending Review
  • Finished

Additional Notes

使用的正则表达式

  1. 英文逗号、冒号+空格 [,:][ ]*
    误判:数字分隔符;地址头;时间
  2. 行尾的英文句号 \.$
    • ([\u4e00-\u9fa5])([\.])([\u4e00-\u9fa5])
  3. 标点符号后的空格 ([(),。?!])([ ])+
    误判:表格;后面有转义字符
  4. 加粗后未空格 ([\u4e00-\u9fa5,。!])([\*]+)([\u4e00-\u9fa5])
    误判:前后是标点符号
已过气,现有的问题见下面的回复👇

Chinese Wiki Completion

- About
- BanchoBot
- Beatmap Editor
finish
ref to 72#
1. `,` => `,`
2. `: ` => `:`
3. `?` => `?`
4. fix wrong use of "OutDate"
5. fix wrong md bold
6. remove useless spaces
1. fix eng punc
2. remove useless space
3. other little fix
1. fix eng punc
2. remove useless space
3. add new space for bold & Italic
4. remove `。` in list
5. other little fix
@inkydragon
Copy link
Author

待我解决一下冲突,实际上已经可以合并了。
还有一些没解决的问题,应该再单开 pr

标点符号未完全修复的部分

未完全修复标点符号主要原因是有未翻译的部分,也就是夹带英文,或者是有其他的干扰因素。

  • FAQ
    【有未翻译部分;使用 HTML 表格】
  • 用户选项
    【使用 HTML 标签;markdown 未正确解析】
  • 什么是互联网中继聊天?
    【有未翻译部分;表格排版不正确】
  • 选项
    【使用HTML标签、表格,并且未正确显示】

发现的其他问题

@Drickle
Copy link

Drickle commented Aug 1, 2019

I'll merge this first

@Drickle Drickle merged commit 8c266bb into osu-translate-zh:master Aug 1, 2019
@inkydragon inkydragon deleted the zh-fix_eng_punctuation branch August 1, 2019 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants