Ensure that configurations can be injected without calling update #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes osgi#780 - it is supposed to be possible to inject configurations that have not been updated so that tests can view the pre and post update state of the system. This was not possible (despite being hinted at in the JavaDoc) as such configurations were always 'new' and therefore were updated with an empty dictionary. This commit fixes the check for this and avoids updating configurations with no properties set if, and only if, the configuration is being injected. It also then fixes a few places where the resulting null properties caused exceptions internally in the ConfigurationExtension. Signed-off-by: Tim Ward <timothyjward@apache.org>
stbischof
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #780 - it is supposed to be possible to inject configurations that have not been updated so that tests can view the pre and post update state of the system. This was not possible (despite being hinted at in the JavaDoc) as such configurations were always 'new' and therefore were updated with an empty dictionary. This commit fixes the check for this and avoids updating configurations with no properties set if, and only if, the configuration is being injected. It also then fixes a few places where the resulting null properties caused exceptions internally in the ConfigurationExtension.