Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flags yellow for annotations that match case insensitive error #1475

Merged
merged 1 commit into from
Jan 8, 2017

Conversation

codefromthecrypt
Copy link
Member

Particularly, this flags existing finagle formatted errors, like so:
"Server Send Error: TimeoutException: socket timed out"

Fixes #1472
See openzipkin/openzipkin.github.io#52

Particularly, this flags existing finagle formatted errors, like so:
"Server Send Error: TimeoutException: socket timed out"

Fixes #1472
See openzipkin/openzipkin.github.io#52
@codefromthecrypt
Copy link
Member Author

screen shot 2017-01-07 at 12 30 44 pm

Using this data:

curl -H "Content-Type: application/json" -s localhost:9411/api/v1/spans -d '[
  {
    "traceId": "4e441824ec2b6a44",
    "id": "4e441824ec2b6a44",
    "name": "get",
    "timestamp": 1478624611519000,
    "annotations": [
    {
      "timestamp": 1478624611519000,
      "value": "Server Send Error: TimeoutException: socket timed out",
      "endpoint": {
        "serviceName": "zipkin-server",
        "ipv4": "192.168.99.1",
        "port": 9411
      }
    },
    {
      "timestamp": 1478624611519001,
      "value": "{\"foo\": \"bar\"}",
      "endpoint": {
        "serviceName": "zipkin-server",
        "ipv4": "192.168.99.1",
        "port": 9411
      }
    }],
    "binaryAnnotations": [
    {
      "key": "bar",
      "value": "bar",
      "endpoint": {
        "serviceName": "zipkin-server",
        "ipv4": "192.168.99.1",
        "port": 9411
      }
    },
      {
        "key": "foo",
        "value": "{\"foo\": \"bar\"}",
        "endpoint": {
          "serviceName": "zipkin-server",
          "ipv4": "192.168.99.1",
          "port": 9411
        }
      }
    ]
  }
  ]'

@codefromthecrypt
Copy link
Member Author

@kevinoliver @mosesn better late than never :P

@codefromthecrypt
Copy link
Member Author

(ps ignore the escaped json in the spans.. that's unrelated)

@codefromthecrypt codefromthecrypt merged commit 57788f8 into master Jan 8, 2017
@codefromthecrypt codefromthecrypt deleted the mark-when-match-error branch January 8, 2017 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant