-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a better default for queuedMaxSpans #266
Labels
Comments
codefromthecrypt
changed the title
Create a sane default for queuedMaxSpans
Create a better default for queuedMaxSpans
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature
Let's make
queuedMaxSpans
a function ofmessageMaxBytes
, instead of an arbitrary default.Rationale
This will better manage the queue backlog, allowing people to use a higher
messageTimeout
than 1s, but still clear the queue faster when under pressure.Example Scenario
A small json span will reach the default 500,000 byte limit by about 1500 spans. A typical one will reach much sooner (typical e.g. sleuth/micrometer which adds more than one tag, and possibly a remote endpoint).
Prior Art
The text was updated successfully, but these errors were encountered: