Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps dependencies #226

Merged
merged 1 commit into from
Aug 31, 2024
Merged

Bumps dependencies #226

merged 1 commit into from
Aug 31, 2024

Conversation

shakuzen
Copy link
Member

@shakuzen shakuzen commented Aug 28, 2024

This is in preparation of doing a release to get the fix out for #224

@reta
Copy link
Contributor

reta commented Aug 30, 2024

Thanks @shakuzen , only if you have time - could you please bump JUnit 5 (5.11.0) and Mockito (5.13.0), could be done after as well, non issue. Thank you.

@shakuzen
Copy link
Member Author

Thanks for the review @reta. Since those are test dependencies I'll bump those in a follow-up PR when I'm back on my work machine on Monday and I'll merge this in to see if we can get any users to test out snapshots with these dependencies upgraded and the mentioned fix before doing the release.

@shakuzen shakuzen merged commit 7538427 into openzipkin:master Aug 31, 2024
3 checks passed
@shakuzen shakuzen deleted the bump branch August 31, 2024 00:28
@shakuzen
Copy link
Member Author

shakuzen commented Sep 4, 2024

@reta I bumped some test dependencies in ab43266. I tried to upgrade junit jupiter to 5.11.0 but then some tests in the storage module failed to be discovered. I'm not sure why - it might be a mismatch in the junit jupiter version with armeria-junit5.

@reta
Copy link
Contributor

reta commented Sep 4, 2024

@reta I bumped some test dependencies in ab43266. I tried to upgrade junit jupiter to 5.11.0 but then some tests in the storage module failed to be discovered. I'm not sure why - it might be a mismatch in the junit jupiter version with armeria-junit5.

Thanks a lot @shakuzen , I will take it (I think I know the issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants