Handle OpenTracing key-value logging, finished work in PR #25 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 26, 2016
bhs
reviewed
Sep 26, 2016
| span.SetTag("tag", "value") | ||
| span.Finish() | ||
| spans := recorder.GetSpans() | ||
| assert.Equal(t, 1, len(spans)) | ||
| assert.Equal(t, 1, len(spans[0].Logs)) | ||
| assert.Equal(t, "event", spans[0].Logs[0].Event) | ||
| assert.Equal(t, "payload", spans[0].Logs[0].Payload) | ||
| // XXX: broken tests |
There was a problem hiding this comment.
yes... thanks for catching... updating...
…JSON encoding them
|
we should probably add to the README a big caution on encoding json, as it will screw up other tooling, such as datastore-layer queries which are used in the zipkin ecosystem. Here's a note about this openzipkin/openzipkin.github.io#52 (comment) Another option is to open a hook for a formatter, similar to most logging libraries, such that people can avoid this problem. |
richardmarshall
pushed a commit
to richardmarshall/zipkin-go-opentracing
that referenced
this pull request
Dec 13, 2016
…_tracing -totalRequests flag and using net/http/httptrace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finishes the work started in PR #25 and handles OpenTracing key-value logging in the same way as Jaeger. If only a single key-value log Field exists with key "event", the payload of the log Field will be used instead of a JSON object with log Fields.