Skip to content

Commit

Permalink
Merge pull request #101 from basvanbeek/thrift
Browse files Browse the repository at this point in the history
another thrift adventure in go land...
  • Loading branch information
basvanbeek authored Mar 13, 2018
2 parents 4c9fbcb + 3f05268 commit 26cf970
Show file tree
Hide file tree
Showing 6 changed files with 43 additions and 16 deletions.
3 changes: 2 additions & 1 deletion collector-kafka_test.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package zipkintracer

import (
"context"
"errors"
"testing"
"time"
Expand Down Expand Up @@ -167,7 +168,7 @@ func deserializeSpan(t *testing.T, e sarama.Encoder) *zipkincore.Span {
s := zipkincore.NewSpan()
mb := thrift.NewTMemoryBufferLen(len(bytes))
_, _ = mb.Write(bytes)
_ = mb.Flush()
_ = mb.Flush(context.Background())
pt := thrift.NewTBinaryProtocolTransport(mb)
err = s.Read(pt)
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion thrift/gen-go/scribe/scribe-consts.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

33 changes: 29 additions & 4 deletions thrift/gen-go/scribe/scribe-remote/scribe-remote.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 9 additions & 8 deletions thrift/gen-go/scribe/scribe.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion thrift/gen-go/zipkincore/zipkinCore-consts.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion thrift/gen-go/zipkincore/zipkinCore.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 26cf970

Please sign in to comment.