Merge pull request #144 from openzipkin-contrib/fix-propagation

Improve handling of span.kind OT tag
openzipkin-contrib · Aug 16, 2019 · 1c852e0 · 1c852e0
2 parents 96c6170 + 201003a
commit 1c852e0
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/tracer.go b/tracer.go
@@ -82,8 +82,16 @@ func parseTagsAsZipkinOptions(t map[string]interface{}) []zipkin.SpanOption {
  tags := map[string]string{}
  remoteEndpoint := &model.Endpoint{}
 
+ var kind string
  if val, ok := t[string(ext.SpanKind)]; ok {
- kind, _ := val.(string)
+ switch kindVal := val.(type) {
+ case ext.SpanKindEnum:
+ kind = string(kindVal)
+ case string:
+ kind = kindVal
+ default:
+ kind = fmt.Sprintf("%v", kindVal)
+ }
  zopts = append(zopts, zipkin.Kind(model.Kind(strings.ToUpper(kind))))
  }