Finish errant ESM upgrade #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orts are actually importable
|
@audiodude Please go ahead with merge and release if you want |
|
@kelson42 I don't have permission without review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ESM conversion was only partially complete in #136. The PR #141 updated it to use the right import syntax.
This PR further updates the index.js file to use the right export syntax for ESM.
Additionally, we add a "dist" test that imports from the finished dist/ folder. This ensures that everything is "hooked up" properly and that all the symbols can be properly imported.
This PR should be released immediately as 3.2.3, because the exports are broken in 3.2.2. (And maybe the changelog should reflect that 3.2.1 and 3.2.2 are faulty).
Sorry!