Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipq40xx: Add support for linksys MR6350 #24

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RolandoMagico
Copy link

@RolandoMagico RolandoMagico commented Dec 19, 2023

Extracted from FW_MR6350_1.1.3.210129_prod.img and repacked.
It's containing only the settings for FCC. EU is identical to FCC.

MD5: 673a0d9f1508f5b6943ceb2ee64f64c8
SHA256: f6197c9e6f28ee0192f3e182b3543ab67209109d29bc493793044231381ce6a3

Based on the thread https://forum.openwrt.org/t/howto-create-ipq40xx-bdf-files

PR adding the device: openwrt/openwrt#14098

@testuser7
Copy link
Contributor

How are BDF files selected?

@RolandoMagico
Copy link
Author

RolandoMagico commented Dec 21, 2023

How are BDF files selected?

Hi @testuser7, that's the first time I tried to create BDF files so I don't have detailled background regarding this topic. Can you please give me some more background regarding your question?

Update: No clear if it answers your question: The BDF contains the data for the main areas. I also checked if there is already a file with the same MD5 in this repository, there isn't.
The file is required for openwrt/openwrt#14098 and is referenced in t the devlice DTS (see https://github.com/openwrt/openwrt/pull/14098/files#diff-12d25e8195d7707e624211ad97b60f2f75c3041cef9c44bdd4f182902b463a93, line 86 and line 91.

@testuser7
Copy link
Contributor

How are BDF files selected?

Hi @testuser7, that's the first time I tried to create BDF files so I don't have detailled background regarding this topic. Can you please give me some more background regarding your question?

I'm not sure if additional BDF files will be used. Currently, there is no mechanism that would allow you to set another variant from the system level.

@RolandoMagico
Copy link
Author

I'm not sure if additional BDF files will be used. Currently, there is no mechanism that would allow you to set another variant from the system level.

Right, as far as I understood from this post, additional BDFs are only included to give "power users" the ability to change them.

@testuser7
Copy link
Contributor

Right, as far as I understood from this post, additional BDFs are only included to give "power users" the ability to change them.

BDF files fcc and eum just have different country code and checksum. Otherwise they are identical.

0x833A - GB
0x8348 - US
OFFSET      bus=ahb,bmi-chip-id=0,bmi-board-id=20,variant=linksys-mr6350-eum.bin   bus=ahb,bmi-chip-id=0,bmi-board-id=20,variant=linksys-mr6350-fcc.bin
--------------------------------------------------------------------------------
0x00000000  20 2F 0D 14 01 01 00 03 7F 12 34 56 3A 83 00 00 |./........4V:...| \ 20 2F 7F 14 01 01 00 03 7F 12 34 56 48 83 00 00 |./........4VH...|
*
OFFSET      bus=ahb,bmi-chip-id=0,bmi-board-id=21,variant=linksys-mr6350-eum.bin   bus=ahb,bmi-chip-id=0,bmi-board-id=21,variant=linksys-mr6350-fcc.bin
--------------------------------------------------------------------------------
0x00000000  20 2F 28 64 01 01 12 34 56 78 90 12 3A 83 00 00 |./(d...4Vx..:...| \ 20 2F 5A 64 01 01 12 34 56 78 90 12 48 83 00 00 |./Zd...4Vx..H...|
*

@RolandoMagico
Copy link
Author

BDF files fcc and eum just have different country code and checksum. Otherwise they are identical.

Thansk for the hint, I removed the EU variant

@Ansuel
Copy link
Member

Ansuel commented Sep 22, 2024

any news on this? can someone summarize the situation?

@RolandoMagico
Copy link
Author

any news on this? can someone summarize the situation?

Hello, This is the first time I created BDF files, but from my point of view nothing else has to be done here. I tested the files with MR6350 and they worked.
If there is anything missing, please tell me and I’ll fix it

@Ansuel
Copy link
Member

Ansuel commented Oct 21, 2024

Honestly I would just include the fcc and remove the tag from the variant. @RolandoMagico can you do that?

Unless you notice big performance degradation, we should stick to the most compatible one across regions (that is FCC)

Extracted from FW_MR6350_1.1.3.210129_prod.img and repacked.
It's containing only the settings for FCC. EU is identical to FCC.

MD5: 673a0d9f1508f5b6943ceb2ee64f64c8
SHA256: f6197c9e6f28ee0192f3e182b3543ab67209109d29bc493793044231381ce6a3

Based on the thread https://forum.openwrt.org/t/howto-create-ipq40xx-bdf-files

Signed-off-by: Roland Reinl <reinlroland+github@gmail.com>
@RolandoMagico
Copy link
Author

@RolandoMagico can you do that?

@Ansuel: Done and rebased

@Ansuel
Copy link
Member

Ansuel commented Oct 21, 2024

Also drop the "variant=linksys-mr6350-fcc" -fcc from variant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants