Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Selenium 3.4+, FF 52 ESR, and add support for Python 3.4+. #152

Merged
merged 80 commits into from
Oct 9, 2017

Commits on Mar 9, 2017

  1. Configuration menu
    Copy the full SHA
    a24da92 View commit details
    Browse the repository at this point in the history
  2. Ensure PIL is available during automated tests on Travis.

    PIL is not a dependency of OpenWPM proper, so it would be inappropriate
    to list it in requirements.txt, but it _is_ used by one of the tests.
    Kludge a direct installation command into .travis.yml.
    zackw committed Mar 9, 2017
    Configuration menu
    Copy the full SHA
    eb1def5 View commit details
    Browse the repository at this point in the history
  3. Apply python-modernize + some hand tidy-ups.

    This should get us 90% of the way to Python 3 support.
    zackw committed Mar 9, 2017
    Configuration menu
    Copy the full SHA
    1c5d935 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    861052c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5c131a7 View commit details
    Browse the repository at this point in the history
  6. Remove uses of the 'commands' module.

    This module was completely removed in Python 3.
    zackw committed Mar 9, 2017
    Configuration menu
    Copy the full SHA
    a5b76e7 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    fc9a7ff View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    43dc955 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    9787c16 View commit details
    Browse the repository at this point in the history
  10. Add missing paren

    zackw committed Mar 9, 2017
    Configuration menu
    Copy the full SHA
    ae722a9 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    4bd069f View commit details
    Browse the repository at this point in the history
  12. Bump Selenium requirement to 3.3.0 or later.

    This may mean install.sh now needs to install something called 'GeckoDriver',
    but let's see if we can get away without it.
    zackw committed Mar 9, 2017
    Configuration menu
    Copy the full SHA
    76f07f0 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2017

  1. Tidy-ups:

     * Rationalize import ordering in some files.
     * Don't run nontrivial code at module scope when invoked as __main__.
     * If jpm is not available, but the .xpi exists, don't bomb out.
    zackw committed Mar 12, 2017
    Configuration menu
    Copy the full SHA
    a19aa8d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3a800c5 View commit details
    Browse the repository at this point in the history
  3. Delete less

    zackw committed Mar 12, 2017
    Configuration menu
    Copy the full SHA
    4408d48 View commit details
    Browse the repository at this point in the history
  4. Remove more dependencies on firefox-bin.

    Since Selenium 3.3 requires a 'geckodriver' executable in
    the PATH, put <root_dir>/firefox-bin in the PATH if it exists,
    and rely on PATH search to find 'firefox'.
    zackw committed Mar 12, 2017
    Configuration menu
    Copy the full SHA
    2ba17e0 View commit details
    Browse the repository at this point in the history
  5. Extension updates.

     * Replace Adblock Plus with uBlock Origin
       (which does not need precached filter lists)
     * Replace Ghostery with Disconnect (ditto)
     * Update HTTPS Everywhere to latest version
    zackw committed Mar 12, 2017
    Configuration menu
    Copy the full SHA
    5b702a9 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2017

  1. Configuration menu
    Copy the full SHA
    414e1ac View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2017

  1. Fix more failures induced by the new Selenium.

    We _might_ be down to just HTTP instrumentation problems at this point.
    zackw committed Mar 15, 2017
    Configuration menu
    Copy the full SHA
    78aaffd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7aa04af View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2017

  1. Further workaround for Python 3 + Selenium 3 + FIFOs.

    The behavior of `open(path, "a+")` differs between Python 2 and Python 3.
    In the latter, it will try to seek to the end, and if this fails (e.g. if
    `path` is a pipe) it will throw an exception.  To work around this we
    have to monkey-patch selenium.webdriver.firefox.service.Service.
    zackw committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    279de8f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6eb51b7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    19e037e View commit details
    Browse the repository at this point in the history
  4. Fix thinko in test_storage_vectors.py.

    sqlite3 fetchall() has always returned an array of tuples even when
    the query returns a single row; Python 2's sloppy cross-type comparisons
    let us get away with it.
    zackw committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    d954c71 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bcb3eda View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c12399f View commit details
    Browse the repository at this point in the history
  7. Work around Selenium bug #3670.

    zackw committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    3d65cff View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7337377 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    2ba308a View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    84050ba View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2017

  1. Overhaul Flash LSO parsing.

    zackw committed Mar 17, 2017
    Configuration menu
    Copy the full SHA
    719fc66 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2017

  1. Configuration menu
    Copy the full SHA
    4b600b2 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2017

  1. Configuration menu
    Copy the full SHA
    6e9db85 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    214354a View commit details
    Browse the repository at this point in the history
  3. PEP8 Fixes

    englehardt committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    3003844 View commit details
    Browse the repository at this point in the history
  4. PEP8 fixes

    englehardt committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    9d0dbb0 View commit details
    Browse the repository at this point in the history
  5. PEP8 fixes

    englehardt committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    53b8940 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1db64ed View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    054a0e8 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d3f0745 View commit details
    Browse the repository at this point in the history
  9. PEP8 Fixes

    englehardt committed Oct 4, 2017
    2 Configuration menu
    Copy the full SHA
    9dd05ec View commit details
    Browse the repository at this point in the history
  10. Updating firefox XPI

    englehardt committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    addb3f7 View commit details
    Browse the repository at this point in the history
  11. PEP8 fixes

    englehardt committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    22e642d View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    11523e5 View commit details
    Browse the repository at this point in the history
  13. PEP8 Fixes

    englehardt committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    402fe02 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    dd01aef View commit details
    Browse the repository at this point in the history
  15. PEP8 Fixes

    englehardt committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    ae88f38 View commit details
    Browse the repository at this point in the history
  16. PEP8 Fixes and cleanup

    englehardt committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    5e4e729 View commit details
    Browse the repository at this point in the history
  17. PEP8 Fixes

    englehardt committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    e47b80a View commit details
    Browse the repository at this point in the history
  18. PEP8 Fixes

    englehardt committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    9e4fc76 View commit details
    Browse the repository at this point in the history
  19. PEP8 Fixes

    englehardt committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    4145b43 View commit details
    Browse the repository at this point in the history
  20. PEP8 Fixes

    englehardt committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    9c7b937 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    0d9e88f View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    19333f4 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    91b6cb9 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    8e81f60 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    ac1128c View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    c2e0a5f View commit details
    Browse the repository at this point in the history
  27. PEP8 Fixes

    englehardt committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    fc54978 View commit details
    Browse the repository at this point in the history
  28. Add support for setting arbitrary browser preferences.

    The commit also moves us from using `firefox_profile` to
    `firefox_options` to set preferences. The Options interface has no
    "frozen" or restricted preferences.
    englehardt committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    5e05e53 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    3329847 View commit details
    Browse the repository at this point in the history
  30. PEP8 Fixes

    englehardt committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    97c29fc View commit details
    Browse the repository at this point in the history
  31. PEP8 Fixes

    englehardt committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    89162ff View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    9c1dddd View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    fcd3c54 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2017

  1. Configuration menu
    Copy the full SHA
    fae8b8d View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2017

  1. Configuration menu
    Copy the full SHA
    a372691 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c6f2bfc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ae81ec0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3b54fa2 View commit details
    Browse the repository at this point in the history
  5. Updating Ghostery

    englehardt committed Oct 7, 2017
    Configuration menu
    Copy the full SHA
    d809b8c View commit details
    Browse the repository at this point in the history
  6. PEP8 Fixes

    englehardt committed Oct 7, 2017
    Configuration menu
    Copy the full SHA
    7eee1d2 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    bb72000 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    0770b3a View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2017

  1. Removing code that strips webdriver self-identification

    Selenium 3 + geckodriver don't (currently) self-identify in the DOM
    englehardt committed Oct 8, 2017
    Configuration menu
    Copy the full SHA
    6895938 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    99d5201 View commit details
    Browse the repository at this point in the history
  3. Don't fallback to system firefox/geckodriver.

    OpenWPM requires a specific version. Instead, let's suggest the user
    run the install script.
    englehardt committed Oct 8, 2017
    Configuration menu
    Copy the full SHA
    dba6c69 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1bf8d79 View commit details
    Browse the repository at this point in the history
  5. Revert to using the multiprocess library (instead of multiprocessing)

    The multiprocess library used `dill` where multiprocessing would
    normally use `pickle`. The main benefit is flexibility in the types of
    arguments we can pass to `run_custom_function`.
    englehardt committed Oct 8, 2017
    Configuration menu
    Copy the full SHA
    d59f81c View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2017

  1. Configuration menu
    Copy the full SHA
    65d64fb View commit details
    Browse the repository at this point in the history